Skip to content

[IMP] account: enable journal item search by amount #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0-rd-accounting-onboarding-malb
Choose a base branch
from

Conversation

shzi-odoo
Copy link

Extended the journal items search view to allow searching by amount

@robodoo
Copy link

robodoo commented Jul 3, 2025

This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged.

Copy link

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr !

@@ -308,6 +308,7 @@
<field name="name"/>
<field name="ref"/>
<field name="invoice_date"/>
<field name="move_id" string="Journal Item Amount" filter_domain="[('move_id.amount_total', '=', self)]"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really what i expected, look for the field debit and credit on the move lines

@malb-odoo
Copy link

Also commit message don't follow the guidelines for the task-id

Copy link

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you can see that you have 2 commits on the pr, squash them 😄 We usually work with only one commit 😄
also still need to check why the venv is there in the git ignore ahah, we will never merge that in production 👀

@shzi-odoo shzi-odoo force-pushed the 18.0-rd-accounting-onboarding-shzi-journal-amount-search branch from 56763d1 to 00406a4 Compare July 7, 2025 11:44
Improved the journal items search functionality by allowing users to find entries that match a specific debit or credit value. Removed
/venv from git ignore

task-4908848
@shzi-odoo shzi-odoo force-pushed the 18.0-rd-accounting-onboarding-shzi-journal-amount-search branch from 00406a4 to 414279a Compare July 7, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants